add labels and ordering for transform propagation and parent update systems in POST_UPDATE stage #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
oh just noticed #1438 that does add one label, but no ordering so doesn't fix the issue |
Contributor
|
There is also #1198 that made them run in different stages. |
Member
|
See also #1423, which should be ready to merge and will change the types of our labels. |
alice-i-cecile
added
C-Bug
Member
Member
|
Looks good to me! We can decide if / how we export labels later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1450
using system name as label, and setting order for transform propagation to happen after parent updates